Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mesh): Add Mesh3D constructor with tolerance check #405

Merged
merged 3 commits into from
Jun 3, 2024
Merged

fix(mesh): Add Mesh3D constructor with tolerance check #405

merged 3 commits into from
Jun 3, 2024

Conversation

ed-p-may
Copy link
Contributor

@ed-p-may ed-p-may commented Jun 3, 2024

Adding a new Mesh3D creation classmethod.

Create a new Mesh3D from face-vertices and use the vertices' is_equivalent to check for duplicate vertices. Similar to using from_face_vertices(..., purge=True), but allows for tolerance when checking vertices against one another.

For background, see: https://discourse.ladybug.tools/t/unexpected-result-creating-mesh3d/25006/

@chriswmackey chriswmackey changed the title Add new Mesh3D constructor with duplicate vertices check fix(mesh): Add Mesh3D constructor with tolerance check Jun 3, 2024
chriswmackey
chriswmackey approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@chriswmackey chriswmackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ed-p-may .
Looks good to me. Merged!

@chriswmackey chriswmackey merged commit dbfb0be into ladybug-tools:master Jun 3, 2024
6 checks passed
@ed-p-may ed-p-may deleted the purge-vertex branch June 3, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswmackey chriswmackey chriswmackey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ed-p-may @chriswmackey